Closed vzurauskas closed 4 years ago
@0crat status
@paulodamaso This PR is not in scope for some reason. Can you add it in?
@0crat in
This pull request #477 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job
@vzurauskas any news?
@victornoel Done.
@paulodamaso looks good to me
@vzurauskas ping
@victornoel @paulodamaso Done.
@vzurauskas @victornoel Thanks!
@rultor merge
@rultor merge
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@paulodamaso Done! FYI, the full log is here (took me 14min)
@0crat status
@0crat status (here)
@victornoel This is what I know about this job in C7JGJ00DP, as in §32:
REV
@paulodamaso can you tell 0crat out, it seemed to have missed this closing event :/
@0crat out
Code review was too long (12 days), architects (@paulodamaso) were penalized, see §55
@vzurauskas please make sure you start all your comments with the name of the user they are referred to, see
@sereshqua Yep, missed one, sorry.
@0crat quality acceptable
449
To calculate NCC correctly, we will use Java
Graph
instead of XSL. This PR introduces Java based CCM Calculus and addstodo
s for further work.