cqfn / jpeek

Hosted and command-line calculator of cohesion metrics for Java code
https://i.jpeek.org
MIT License
209 stars 81 forks source link

#449 - Begin Java CCM. #477

Closed vzurauskas closed 4 years ago

vzurauskas commented 4 years ago

449

To calculate NCC correctly, we will use Java Graph instead of XSL. This PR introduces Java based CCM Calculus and adds todos for further work.

vzurauskas commented 4 years ago

@0crat status

0crat commented 4 years ago

@0crat status (here)

@vzurauskas This is what I know about this job in C7JGJ00DP, as in §32:

vzurauskas commented 4 years ago

@paulodamaso This PR is not in scope for some reason. Can you add it in?

paulodamaso commented 4 years ago

@0crat in

0crat commented 4 years ago

This pull request #477 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

victornoel commented 4 years ago

@vzurauskas any news?

vzurauskas commented 4 years ago

@victornoel Done.

victornoel commented 4 years ago

@paulodamaso looks good to me

0crat commented 4 years ago

@victornoel/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

victornoel commented 4 years ago

@vzurauskas ping

vzurauskas commented 4 years ago

@victornoel @paulodamaso Done.

paulodamaso commented 4 years ago

@vzurauskas @victornoel Thanks!

paulodamaso commented 4 years ago

@rultor merge

rultor commented 4 years ago

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 4 years ago

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 14min)

victornoel commented 4 years ago

@0crat status

0crat commented 4 years ago

@0crat status (here)

@victornoel This is what I know about this job in C7JGJ00DP, as in §32:

victornoel commented 4 years ago

@paulodamaso can you tell 0crat out, it seemed to have missed this closing event :/

paulodamaso commented 4 years ago

@0crat out

0crat commented 4 years ago

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 4 years ago

Code review was too long (12 days), architects (@paulodamaso) were penalized, see §55

sereshqua commented 4 years ago

@vzurauskas please make sure you start all your comments with the name of the user they are referred to, see

vzurauskas commented 4 years ago

@sereshqua Yep, missed one, sorry.

sereshqua commented 4 years ago

@0crat quality acceptable