search

cqfn / jpeek

Hosted and command-line calculator of cohesion metrics for Java code
https://i.jpeek.org
MIT License
209 stars 81 forks source link

Extracting report build into separate method #544

Closed starkda closed 8 months ago

starkda commented 8 months ago

resolution of issue https://github.com/cqfn/jpeek/issues/461 Extracted part of App.analyze method, which responsible for building report into separate method App.buildReport. To make code simplier, added enum that represents Metrics and their meta-information.

starkda commented 8 months ago

@yegor256 could you please review it

yegor256 commented 8 months ago

@starkda looks good! Now, try to run mvn clean install -Pqulice locally and see the result.

starkda commented 8 months ago

@yegor256 i've fixed all checkstyle issues. Now workflow supposed to pass

yegor256 commented 8 months ago

@rultor merge

rultor commented 8 months ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 months ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 18min)