search

cqfn / pdd

Command line toolkit for collecting TODO markers from your code, known as Puzzle Driven Development (PDD)
https://www.0pdd.com
MIT License
77 stars 26 forks source link

[#132] rake_task.rb:10-12: Needs to have more parameters to run... #173

Closed Doldrums closed 3 years ago

Doldrums commented 3 years ago

This is a fix of the puzzle 125-7d80a284 from #132 . The puzzle was created by Alexey Vinogradov on 10-Jul-19.

Doldrums commented 3 years ago

@yegor256 review please

AntistasII commented 3 years ago

@yegor256 review this PR please

yegor256 commented 3 years ago

@Doldrums all looks good, just one small comment

Doldrums commented 3 years ago

@yegor256 thanks, just deleted it

yegor256 commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@doldrums @yegor256 Oops, I failed. You can see the full log here (spent 3min)

/home/r/repo/test_assets/cambria.woff is a binary file (87722 bytes)
/home/r/repo/test_assets/aladdin.jpg is a binary file (115758 bytes)
/home/r/repo/test_assets/elegant-objects.png is a binary file (30969 bytes)
/home/r/repo/test_assets/favicon.ico is a binary file (3038 bytes)
/home/r/repo/test_assets/article.pdf is a binary file (84533 bytes)
Reading .simplecov ...
Reading Rakefile ...
Reading Gemfile ...
Reading .0pdd.yml ...
Reading .github/ISSUE_TEMPLATE.md ...
Reading .github/PULL_REQUEST_TEMPLATE.md ...
Reading .overcommit.yml ...
Reading cucumber.yml ...
Reading .travis.yml ...
Reading LICENSE.txt ...
Reading test/test_sources.rb ...
Reading test/test_rake_task.rb ...
Reading test/test_duplicates.rb ...
Reading test/test_text.rb ...
Reading test/test_roles.rb ...
Reading test/test_estimates.rb ...
Reading test/test__helper.rb ...
Reading .pdd ...
Reading .rultor.yml ...
Reading lib/pdd/rake_task.rb ...
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
Puzzle 125-242e0931 30/DEV at lib/pdd/rake_task.rb
Reading lib/pdd/sources.rb ...
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
Puzzle 98-9de926c6 30/DEV at lib/pdd/sources.rb
Reading lib/pdd/rule/duplicates.rb ...
Reading lib/pdd/rule/text.rb ...
Reading lib/pdd/rule/roles.rb ...
Reading lib/pdd/rule/estimates.rb ...
Reading lib/pdd/puzzle.rb ...
Reading lib/pdd/version.rb ...
Reading lib/pdd.rb ...
Reading appveyor.yml ...
Reading assets/puzzles.xsd ...
Reading assets/puzzles.xsl ...
Reading .rubocop.yml ...
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
Puzzle 123-9786ef4c 30/DEV at .rubocop.yml
Reading .gitignore ...
Reading pdd.gemspec ...
Reading Gemfile.lock ...
Reading features/rake.feature ...
Reading features/support/env.rb ...
Reading features/gem_package.feature ...
Reading features/step_definitions/steps.rb ...
Reading bin/pdd ...
Reading .gitattributes ...
\u001b[31mERROR\u001b[0m: Puzzle lib/pdd/rake_task.rb:35-35 has a very short description of just 5 words while a minimum of 20 is required
\u001b[31mERROR\u001b[0m: 1 errors, see log above
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/cqfn/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/cqfn/pdd/blob/master/README.md.
Exit code is 1
container b4e19c4f967f48067bd8523c8aae0d55760f71e9dacd014dd7fb2b4eb9c37afa is dead
Fri Sep 24 10:34:45 CEST 2021
Doldrums commented 3 years ago

@yegor256 fixed this puzzle description length, actually i didn't get this issue while running bundle exec rake maybe we should add some checks

AntistasII commented 3 years ago

@yegor256 Please look at Arina's comment and PR

yegor256 commented 3 years ago

@rultor merge

rultor commented 3 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 3 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)