cqfn / pdd

Command line toolkit for collecting TODO markers from your code, known as Puzzle Driven Development (PDD)
https://www.0pdd.com
MIT License
76 stars 25 forks source link

[#102] use gem to detect binary file - windows support #186

Closed mbao01 closed 2 years ago

mbao01 commented 2 years ago

✅ Detect binary file in any OS (window, linux, mac)

yegor256 commented 2 years ago

@rultor merge

rultor commented 2 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 2 years ago

@rultor merge

@mbao01 @yegor256 Oops, I failed. You can see the full log here (spent 7min)

/home/r/.ruby/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil
/home/r/.ruby/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil
/home/r/.ruby/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil
/home/r/.ruby/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil
/home/r/.ruby/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil
/home/r/.ruby/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil
/home/r/.ruby/gems/rake-12.0.0/lib/rake/application.rb:378: warning: deprecated Object#=~ is called on Proc; it always returns nil
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m/tmp/test20220110-10860-a0jumj/pdd/lib/pdd/version.rb:26: warning: already initialized constant PDD::VERSION
/home/r/repo/lib/pdd/version.rb:26: warning: previous definition of VERSION was here
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

24 scenarios (\u001b[36m1 skipped\u001b[0m, \u001b[32m23 passed\u001b[0m)
107 steps (\u001b[36m7 skipped\u001b[0m, \u001b[32m100 passed\u001b[0m)
0m7.754s
/home/r/.ruby/gems/cucumber-core-3.1.0/lib/cucumber/core/test/result.rb:12: warning: calling private without arguments inside a method may not have the intended effect
/home/r/.ruby/gems/cucumber-core-3.1.0/lib/cucumber/core/test/result.rb:12: warning: calling private without arguments inside a method may not have the intended effect
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
Coverage report generated for Cucumber Features, Unit Tests to /home/r/repo/coverage. 341 / 357 LOC (95.52%) covered.
/home/r/.ruby/gems/json-1.8.6/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated
Running RuboCop...
Inspecting 27 files
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

27 files inspected, \u001b[32mno offenses\u001b[0m detected
Running xcop...
Inspecting 2 files...
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m
2 files checked, everything looks \u001b[32mpretty\u001b[0m
grep -q -r '2014-2022'     --include '*.rb'     --include '*.txt'     --include 'Rakefile'     .
rake aborted!
Command failed with status (1): [grep -q -r '2014-2022'     --include '*.rb...]
/home/r/repo/Rakefile:85:in `block in <top (required)>'
/home/r/.ruby/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
/home/r/.ruby/bin/ruby_executable_hooks:24:in `eval'
/home/r/.ruby/bin/ruby_executable_hooks:24:in `<main>'
Tasks: TOP => default => copyright
(See full trace by running task with --trace)
container 5748d08bd8c055c53d84af1dc6f6fe5161e8d6f141ded8ee5799a738679e9943 is dead
Mon Jan 10 17:01:57 CET 2022
mbao01 commented 2 years ago

I think the copyright dates need to change to 2022. I will create an issue to address this @yegor256

yegor256 commented 2 years ago

@rultor merge

rultor commented 2 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 2 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 6min)