search

cqfn / pdd

Command line toolkit for collecting TODO markers from your code, known as Puzzle Driven Development (PDD)
https://www.0pdd.com
MIT License
76 stars 25 forks source link

Ignoring bug about too many leading spaces #193

Closed baudoliver7 closed 2 years ago

baudoliver7 commented 2 years ago

For example, when I add this puzzle to my code :

* @todo #59:30min Generate code for JOOQ.
*  We need first set up JOOQ in the project to generate objects based
*  on tables of database. see theses links:
*   - https://www.jooq.org/doc/3.16/manual/getting-started/tutorials/jooq-in-7-steps/jooq-in-7-steps-step3/
*   - https://www.jooq.org/doc/3.16/manual/getting-started/tutorials/jooq-in-7-steps/jooq-in-7-steps-step4/

and run pdd like this on my project :

pdd -f /dev/null

Everything is ok so far.

But, 0pdd is unable to create the puzzle with this error message :

ERROR: src/main/java/com/supervisor/server/Main.java; puzzle at line #46; Too many leading spaces at 49:4; make sure all lines that include the puzzle body start at position #5.
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

See logs here

On another side, I think we should allow someone to create a puzzle designed like the one above :)

yegor256 commented 2 years ago

@baudoliver7 I believe it's a feature of a new version. @mbao01 right?

baudoliver7 commented 2 years ago

@yegor256 @mbao01 Here is another puzzle (on artipie this time) that fails also :

* @todo #449:30min Support running DockerProxyIT test on Windows.
*  Running test on Windows uses `mcr.microsoft.com/dotnet/core/runtime` image.
*  Loading this image manifest fails with
*  "java.lang.IllegalStateException: multiple subscribers not supported" error.
*  It seems that body is being read by some other entity in Artipie,
*  so it requires investigation.

With the same message, preventing pdd to generate any puzzle on the project :

Reading src/test/java/com/artipie/docker/DockerProxyIT.java...
ERROR: src/test/java/com/artipie/docker/DockerProxyIT.java; puzzle at line #28; Too many leading spaces at 36:3; make sure all lines that include the puzzle body start at position #4.
If you can't understand the cause of this issue or you don't know how to fix it, please submit a GitHub issue, we will try to help you: https://github.com/yegor256/pdd/issues. This tool is still in its beta version and we will appreciate your feedback. Here is where you can find more documentation: https://github.com/yegor256/pdd/blob/master/README.md.
Exit code is 1

See logs here for more details.

mbao01 commented 2 years ago

@yegor256 this has been fixed in #187 but has not been released yet.

@baudoliver7 thank you for raising this issue. Issue #163 discusses the same points. Now, leading spaces are not needed in creating a puzzle. This will be out in the next release.

baudoliver7 commented 2 years ago

@mbao01 Great ! We look forward to this new version being released and used by 0pdd. Thanks for this achievement !