search

cqfn / pdd

Command line toolkit for collecting TODO markers from your code, known as Puzzle Driven Development (PDD)
https://www.0pdd.com
MIT License
76 stars 25 forks source link

[#197] Avoiding repeated calls #198

Closed Doldrums closed 2 years ago

Doldrums commented 2 years ago

Solving issue #197.

Doldrums commented 2 years ago

@yegor256 please review

Doldrums commented 2 years ago

@yegor256 It is important to clarify that the call to the #check_rules() method should occur after the call to #match_markers(). Since it is in the match_markers that the string is checked for the presence of keywords. So it is logical to combine these checks, which will allow us to win in optimization by excluding obviously unnecessary compilations of regular expressions.

yegor256 commented 2 years ago

@rultor merge

rultor commented 2 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 2 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)