cqfn / pdd

Command line toolkit for collecting TODO markers from your code, known as Puzzle Driven Development (PDD)
https://www.0pdd.com
MIT License
76 stars 25 forks source link

[#224] Add description for multiline puzzle #237

Closed pnatashap closed 7 months ago

pnatashap commented 7 months ago
  1. Examples for multiline puzzles
  2. Remove unsupported examples

Fix #224

pnatashap commented 7 months ago

@php-coder @yegor256 please take a look

yegor256 commented 7 months ago

@pnatashap looks good to me. @php-coder WDYT?

php-coder commented 7 months ago

Also, I suggest to add Fix #224 to the PR description, so the GitHub will close the related issue once the PR gets merged.

yegor256 commented 7 months ago

@pnatashap please, make the fixed suggested and then we'll merge this one

pnatashap commented 7 months ago

@php-coder @yegor256 please take a look

php-coder commented 7 months ago

LGTM

But it breaks backward compatibility :( Ideally, we should keep it and accept both styles some time simultaneously with a warning about usage of old-style comments. But as I'm not using 0pdd anymore, so now I don't care about that much as I my repos won't have new issues created and the old one closed because of this change...

yegor256 commented 7 months ago

@volodya-lombrozo can you please take a look at this one. Do you see any problems?

pnatashap commented 7 months ago

LGTM

But it breaks backward compatibility :( Ideally, we should keep it and accept both styles some time simultaneously with a warning about usage of old-style comments. But as I'm not using 0pdd anymore, so now I don't care about that much as I my repos won't have new issues created and the old one closed because of this change...

Actually space as a non breaking separator was a change from previous week and not released (and was not presented in documentation) so it is not about backward capability. Removed one-line examples just not supported (I do not see any test for them)

yegor256 commented 7 months ago

@pnatashap something wrong here with the codecov task?

pnatashap commented 7 months ago

There is a error on report upload [2024-01-31T17:00:02.755Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')} Rerun button is not available for me, but it should work, as report created correctly

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8db7aaa) 95.50% compared to head (317b976) 95.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #237 +/- ## ========================================== + Coverage 95.50% 95.69% +0.19% ========================================== Files 10 10 Lines 356 372 +16 ========================================== + Hits 340 356 +16 Misses 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pnatashap commented 7 months ago

codecov-action@v4 solves the issue with upload... will check why it is decreased :) Check code coverage on PR creation in action

pnatashap commented 7 months ago

@yegor256 please take a look

yegor256 commented 7 months ago

@rultor merge

rultor commented 7 months ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 7 months ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)