Closed pnatashap closed 7 months ago
@php-coder @yegor256 please take a look
@pnatashap looks good to me. @php-coder WDYT?
Also, I suggest to add Fix #224
to the PR description, so the GitHub will close the related issue once the PR gets merged.
@pnatashap please, make the fixed suggested and then we'll merge this one
@php-coder @yegor256 please take a look
LGTM
But it breaks backward compatibility :( Ideally, we should keep it and accept both styles some time simultaneously with a warning about usage of old-style comments. But as I'm not using 0pdd anymore, so now I don't care about that much as I my repos won't have new issues created and the old one closed because of this change...
@volodya-lombrozo can you please take a look at this one. Do you see any problems?
LGTM
But it breaks backward compatibility :( Ideally, we should keep it and accept both styles some time simultaneously with a warning about usage of old-style comments. But as I'm not using 0pdd anymore, so now I don't care about that much as I my repos won't have new issues created and the old one closed because of this change...
Actually space as a non breaking separator was a change from previous week and not released (and was not presented in documentation) so it is not about backward capability. Removed one-line examples just not supported (I do not see any test for them)
@pnatashap something wrong here with the codecov task?
There is a error on report upload
[2024-01-31T17:00:02.755Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
Rerun button is not available for me, but it should work, as report created correctly
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8db7aaa
) 95.50% compared to head (317b976
) 95.69%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
codecov-action@v4 solves the issue with upload... will check why it is decreased :) Check code coverage on PR creation in action
@yegor256 please take a look
@rultor merge
Fix #224