search

cqfn / veniq

Veniq uses Machine Learning to analyze source code, find possible refactorings, and suggest those that seem optimal
MIT License
20 stars 3 forks source link

Design for d6tflow framework #123

Open lyriccoder opened 3 years ago

lyriccoder commented 3 years ago

We can split our tasks to the following Task of d6tflow framework Task1 -> open Java file with correct encoding Task2 -> remove all spaces and comments in it and save to another file Task3 -> open file, find all method which can be inlined. Save target, extracted, full_ast, text_file, filename, row_csv from Task2 Task4 -> Task3 get target, extracted and filter it. Save target, extracted, full_ast, text_file, filename, row_csv from Task3 Task5 -> get result from Task3 and filter limited cases. Save target, extracted, full_ast, text_file, filename, row_csv from Task4 Task6 -> Inline Method, save file, row_csv Task 7 -> save row_csv to global DataFrame

Possible problems: 1) We have to save our preprocessed files to external memory, since we will have lots of files and it won't have enough memory to keep them in cache. Also, we have to keep them also in external memory since, it's our dataset which will be validated. Seems, it cannot be done due to https://github.com/d6t/d6tflow/issues/6 2) We need to save different types of objects: ast tree, text. Seems, it's difficult: https://github.com/d6t/d6tflow/issues/26

KatGarmash commented 3 years ago

@lyriccoder can you please write this issue in terms of Problem and Proposed solution

Also, give the issue a more informative name

lyriccoder commented 3 years ago

Bonobo can run tasks in parallel (it is written, i can't check it). Also, it can run child tasks automatically.

I didn't solve the issue with aggregation of results to global csv: transform

KatGarmash commented 3 years ago

@lyriccoder

Some comments: (1) step find_EMS: do we need to extract AST at this stage? it's an expensive operation (i think) and it'd be nice to do it after filtering (2) in the abstract representation of the dataflow, I'd merge filters into one "Filter", as we may modify the sequence of filters in the future (3) in ur representation of dataflow, you write "prev filters": you don't actually pass filters, but some filtered items. can you specify them?

lyriccoder commented 3 years ago

1) Of course we need, how can we compare method declaration and method invocation and iterate over all methods? We can do it only with ast 2) I've done it since we can omit some filter, if we merge them we wont; be able to discard them one by one 3) It's the previous results, you are right. It has previous results and plus one filter.

E.g., if we filter by ncss, we add to the all data ncss value. If we filter invocations by the SINGLE_STATEMENT_IN_IF filter, we add it to the final result

KatGarmash commented 3 years ago

(1) OK. do we need to pass the AST to the next step then?

(2) I meant, just have a more abstract representation processing steps. Merging them is a way of abstraction

(3) Filter is not data, it s an operator. Or do you mean something else by "filter"? The edges have to be labeled with data only. Nodes are operators. You can maybe write "filters(data)"

lyriccoder commented 3 years ago

1) we need full ast for inlining 2) -- 3) I need to replace the word filter with data