search

cqframework / CQL-Formatting-and-Usage-Wiki

A collaborative workspace for the development of CQL formatting conventions and usage patterns for artifact development. The home of Cooking with CQL Examples, visit the wiki for more.
https://github.com/cqframework/CQL-Formatting-and-Usage-Wiki/wiki
65 stars 24 forks source link

code systems not in VSAC #17

Closed p9g closed 3 years ago

p9g commented 3 years ago

https://github.com/cqframework/CQL-Formatting-and-Usage-Wiki/blob/master/Source/Libraries/CumulativeMedicationDuration-1.0.000.cql#L9-L38

These 2 code systems, and the associated codes, are not in VSAC. I could not find the code systems using https://vsac.nlm.nih.gov/context/cs

Looking for them using FHIR also comes up empty curl -s -k -u apiKey:your-key-here https://cts.nlm.nih.gov/fhir/r4/CodeSystem?_format=json^&name=timing
curl -s -k -u apiKey:your-key-here https://cts.nlm.nih.gov/fhir/r4/CodeSystem?_format=json^&name:contains=timing

Therefore, these codes cannot be added when creating this library in MAT (for QDM); apparently MAT does not verify with VSAC that those code systems exist since a FHIR version is in MAT.

http://tx.fhir.org/r4/CodeSystem?_format=json&name:contains=timing finds 4 code systems including both urn:oid:2.16.840.1.113883.4.642.4.76 and urn:oid:2.16.840.1.113883.5.139 (with 2 versions of ..5.139)

https://r4.ontoserver.csiro.au/fhir/CodeSystem?_format=json&name:contains=timing finds them

JSRankins commented 3 years ago

@p9g These code systems are in THO. FHIR code systems are mostly not in VSAC. These two code systems serve as example. Measure developers needed to work with FHIR code systems not in VSAC for FHIR-based eCQMs. MAT app is doing what was requested by community. On the other hand, QDM in MAT only allows code systems to be provide in measures if they are in VSAC.

robmcclure commented 3 years ago

This specific need aligns with the point I made earlier this week - that FHIR eCQM IGs (and potentially HQMF-based) need tooling that allows measure devs the ability to include code systems specified in places other than VSAC. Is the question that given the tooling can not use THO code systems, we need an interim solution? Perhaps we include these common code systems of need into whatever common quality measure IG all the measures must include (sorry to not know that right off) and in doing that maybe make a common code system library. Is that under discussion? . . . All content represents my view only Robert McClure MD FAMIA FHL7 (he/him) : President, MD Partners, Inc. 303.926.6771 : @. @.>

On Aug 27, 2021, at 9:00 AM, JSRankins @.***> wrote:

@p9g https://github.com/p9g These code systems are in THO. FHIR code systems are mostly not in VSAC. These two code systems serve as example. Measure developers needed to work with FHIR code systems not in VSAC for FHIR-based eCQMs. MAT app is doing what was requested by community. On the other hand, QDM in MAT only allows code systems to be provide in measures if they are in VSAC.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cqframework/CQL-Formatting-and-Usage-Wiki/issues/17#issuecomment-907184427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIGCI6DDVCUDWOBRZJ4EAOLT66D6HANCNFSM5C3QHFSQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

p9g commented 3 years ago

Note that https://github.com/cqframework/CQL-Formatting-and-Usage-Wiki/commit/e534abea12b68bc690a6ed75e9a24bf88387f2d1 deleted the 1.0.000 (QDM 5.6) library linked in my original issue above. This comment was about the QDM version of CMD; QDM measures in MAT must pull value sets from VSAC, so it was an issue if those value sets were used.
https://github.com/cqframework/CQL-Formatting-and-Usage-Wiki/commit/09ad8eae31981b5bec1b04172e407e0de6486961 added v 0.1.000 of CMD which uses Direct Referenced Codes (DRC) instead of those value sets. https://github.com/cqframework/CQL-Formatting-and-Usage-Wiki/blob/master/Source/Cooking%20With%20CQL/57/CumulativeMedicationDuration-0.3.000.cql is newer. I did not intend this issue to be about FHIR measures and where to find value sets; I probably should have mentioned QDM in the title.

p9g commented 3 years ago

Given updates in the QDM CMD library, this can be closed.

JSRankins commented 3 years ago

Hi @p9g My comments were in reference to the following: apparently MAT does not verify with VSAC that those code systems exist since a FHIR version is in MAT. The community wanted to use code systems that were not in VSAC but that were in FHIR. Hope that helps.

p9g commented 3 years ago

Thanks. I think I didn't realize at the time that MAT allows copy and paste of value sets into CQL Editor and does not check that those value sets are in VSAC. For QDM, MAT does not allow pasting of valuesets (etc) into the CQL editor and as you stated on 27 Aug QDM in MAT only allows code systems to be provide in measures if they are in VSAC.