Closed antvaset closed 2 weeks ago
Attention: Patch coverage is 66.66667%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 62.26%. Comparing base (
e00c396
) to head (74bf237
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...engine/elm/executing/TruncatedDivideEvaluator.java | 0.00% | 3 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A few small changes:
null
when base is 1. The spec saysIf the result of the operation cannot be represented, the result is null.
(source). Added new test case forlog_1(2)
in addition tolog_1(1)
.(-10^28^+1)/10^8^..(10^28^-1)/10^8^
, i.e.-99999999999999999999.99999999..99999999999999999999.99999999
(20 nines before the decimal point and 8 nines after the decimal point).10L div 3L
now returns3L
as expected.null
if the element argument isnull
as per the spec.Includes_NegInfBegIncludesDateIvl
test in theCqlTestSuite
library which was failing in NZ timezone: When the lower boundary of DateTime-typed Interval isnull
, it is set tominimum DateTime
which strictly speaking returnsDateTime(1, 1, 1, 0, 0, 0, 0, 0)
and notDateTime(1, 1, 1, 0, 0, 0, 0)
.