cqframework / clinical_quality_language

Clinical Quality Language (CQL) is an HL7 specification for the expression of clinical knowledge that can be used within both the Clinical Decision Support (CDS) and Clinical Quality Measurement (CQM) domains. This repository contains complementary tooling in support of that specification.
https://confluence.hl7.org/display/CDS/Clinical+Quality+Language
Apache License 2.0
251 stars 121 forks source link

Null handling by ProperContains, ProperIncludedIn, ProperIncludes, ProperIn evaluators. #1370

Open antvaset opened 2 weeks ago

antvaset commented 2 weeks ago

This fixes how the ProperContains, ProperIncludedIn, ProperIncludes, ProperIn evaluators handle nulls. The CQL specification states that:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.72%. Comparing base (e00c396) to head (26c6921). Report is 8 commits behind head on master.

Files Patch % Lines
.../engine/elm/executing/ProperIncludesEvaluator.java 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1370 +/- ## ============================================ + Coverage 62.26% 63.72% +1.45% + Complexity 6951 2665 -4286 ============================================ Files 492 492 Lines 27727 27715 -12 Branches 5506 5502 -4 ============================================ + Hits 17265 17661 +396 + Misses 8198 7821 -377 + Partials 2264 2233 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JPercival commented 1 week ago

@antvaset - We have a goal of >=80% test coverage for new/updated code. Can you add tests for the Evaluators that gets the patch up to 80%?

antvaset commented 1 week ago

Hi @JPercival, I've squeezed in some more coverage. This is the most we can do I believe.