Open antvaset opened 2 weeks ago
Attention: Patch coverage is 85.71429%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 63.72%. Comparing base (
e00c396
) to head (26c6921
). Report is 8 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
.../engine/elm/executing/ProperIncludesEvaluator.java | 66.66% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@antvaset - We have a goal of >=80% test coverage for new/updated code. Can you add tests for the Evaluators that gets the patch up to 80%?
Hi @JPercival, I've squeezed in some more coverage. This is the most we can do I believe.
This fixes how the ProperContains, ProperIncludedIn, ProperIncludes, ProperIn evaluators handle nulls. The CQL specification states that:
T properly included in List<T>
expression (ProperIn(T, List<T>)
in ELM) evaluates to null if either argument is null (link).List<T> properly included in List<T>
(ProperIncludedIn(List<T>, List<T>)
in ELM).List<T> properly includes T
(ProperContains(List<T>, T)
in ELM) evaluates to null if either argument is null (link).List<T> properly includes List<T>
(ProperIncludes(List<T>, List<T>)
in ELM).