Closed antvaset closed 4 months ago
Formatting check succeeded!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.73%. Comparing base (
7e91478
) to head (67cf75d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR removes CQL library-based tests for CQL expressions in favour of XML-based tests. All library tests that are not present in XML are moved to XML.
This is a continuation of https://github.com/cqframework/clinical_quality_language/pull/1383 and addresses https://github.com/cqframework/clinical_quality_language/issues/1376.
The following library tests needed to be modified when moved to XML: 1)
CqlArithmeticFunctionsTest/Exp/Exp1Long
- changed the expression fromExp(1L)
toRound(Exp(1L), 8)
(also changed the name toExp1L
). Fixing the precision makes the test more robust and consistent withCqlArithmeticFunctionsTest/Exp/Exp1
. 2)CqlArithmeticFunctionsTest/Negate/NegateMaxLong
- set the expected result to-9223372036854775807L
(-(2^63 - 1)).This PR addresses the tests for aggregate functions, aggregate queries, and arithmetic functions, to make it easier to review and merge early. The rest will be covered in subsequent PRs.
I used this TS script to compare the test files: