Closed ddieppois closed 7 months ago
Should we also be closing the writer instead of flushing?
Also, should we be closing(slash flushing) on finally, not in the body?
see lines 3859 and 3868, etc.
I know this is outside the implementation, but maybe an opportunity to improve the code before we commit?
The writer is automatically closed if it's open inside the try, that one is covered
@rob-reynolds - This pattern is called "try-with-resources" in Java: https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
DataElement and ContactDataElements fix. Added dynamique library pick based on the profile TODO: how to pick the right context. How to switch to the right library for DataElements. Added tests
Description : PR to fix acceleratorKit bugs. CQL files generation if mostly fixed. We need to define the proper factor to pick the context and the library.
DataElement and ContactDataElements fix. Added dynamique library pick based on the profile TODO: how to pick the right context. How to switch to the right library for DataElements. Added tests
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0