Closed c-schuler closed 3 months ago
Attention: Patch coverage is 0%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 20.25%. Comparing base (
f322c86
) to head (35ec89c
).
Files | Patch % | Lines |
---|---|---|
...ssor/argument/RefreshLibraryArgumentProcessor.java | 0.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Implementers reported invalid ELM XML generation using the Library refresh operation with latest tooling (v3.4.0).
For description of issue and steps to reproduce see https://github.com/reason-healthcare/CQFToolingBug/blob/main/README.md
Additionally, an issue was reported with the shouldApplySoftwareSystemStamp parameter being ignored by the Library refresh operation.
Replaced Jackson ELM serialization with JAXB
Added shouldApplySoftwareSystemStamp to Library refresh parameters
Added tests (also tested in the repro repository referenced above)
Removed tooling-cli directory from tooling module (seemed like that was committed by mistake(?))
Github Issue:
[x] I've read the contribution guidelines
[x] Code compiles without errors
[x] Tests are created / updated
[ ] Documentation is created / updated
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0