Closed kjmahalingam closed 3 years ago
Merging #245 (9c6250c) into master (4234b50) will decrease coverage by
0.09%
. The diff coverage is92.85%
.
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 92.39% 92.29% -0.10%
==========================================
Files 47 47
Lines 4008 4034 +26
==========================================
+ Hits 3703 3723 +20
- Misses 305 311 +6
Impacted Files | Coverage Δ | |
---|---|---|
src/elm/overloaded.js | 95.39% <71.42%> (-1.16%) |
:arrow_down: |
src/datatypes/datetime.js | 93.93% <100.00%> (+0.21%) |
:arrow_up: |
src/elm/arithmetic.js | 96.74% <100.00%> (ø) |
|
src/util/math.js | 77.36% <0.00%> (-2.11%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4234b50...9c6250c. Read the comment docs.
Various fixes to tests and/or logic to address the following test failures:
CqlArithmeticFunctionsTest.Precision.PrecisionYear
CqlArithmeticFunctionsTest.Precision.PrecisionDateTimeMilliseconds
CqlArithmeticFunctionsTest.Precision.PrecisionTimeMinutes
CqlArithmeticFunctionsTest.Precision.PrecisionTimeMilliseconds
Does not fix
PrecisionDecimal
since this requires additional work with integers and decimals as in #204Fixes #160
Pull requests into cql-execution require the following. Submitter and reviewer should ✔ when done. For items that are not-applicable, mark "N/A" and ✔.
CDS Connect and Bonnie are the main users of this repository. It is strongly recommended to include a person from each of those projects as a reviewer.
Submitter:
yarn run test:plus
to run tests, lint, and prettier)cql4browsers.js
built withyarn run build:browserify
if source changed.Reviewer:
Name: