search

cqframework / draft-measures

Draft Measures Working Content Repository
9 stars 19 forks source link

Check for null Condition.abatement in "Prevalence Period" function so… #57

Closed matthewtiller closed 3 years ago

matthewtiller commented 4 years ago

… that

it will not result in an interval ending in an open null

matthewtiller commented 4 years ago

After the discussion on 8/5 about CQL's conversion of closed, null Interval starts/ends, I realize my initial fix to MATGlobal is insufficient. I think it can still be fixed, so I will have another commit. Also, I will account for closed interval starts, which I did not do originally.

matthewtiller commented 3 years ago

The original goal of this PR was to fix the behavior of "Prevalence Period" to avoid it producing an interval ending in an open null. Specifically, if the input Condition's onset ended in a closed null, then "Prevalence Period" would change it to an open null.

This fix is insufficient, I think, because of "Normalize Abatement", which is used in "Prevalence Period," is inconsistent with how it closes intervals as well.