cqframework / sample-content-ig

Sample Content IG
Apache License 2.0
7 stars 13 forks source link

Update to Related Artifact Dependencies field #88

Open juliet-rubini opened 4 months ago

juliet-rubini commented 4 months ago

Please add display to the following code (starting around line 483) so that value set names also show in the output (and not just the OIDs)

                {% if Measure.relatedArtifact.where(type = 'depends-on').exists() and
                        Measure.extension.where(url = 'http://hl7.org/fhir/us/cqfmeasures/StructureDefinition/cqfm-effectiveDataRequirements').exists().not() %}
                    <p><b>Dependencies</b></p>
                    <ul>
                        {% for artifact in Measure.relatedArtifact.where(type = 'depends-on') %}
                            <li>{{artifact.resource}}</li>
                        {% endfor %}
                    </ul>
                {% endif %}
echicoine-icf commented 4 months ago

PR: https://github.com/cqframework/sample-content-ig/pull/93

JSRankins commented 3 months ago

The fix does not appear to have resolved the issue. According to MADiE release notes, v0.4.3 tag is used in the latest MADiE release, but only the canonicals for the value sets are still coming out. CMS161FHIR-v0.2.000-FHIR4.zip

JSRankins commented 3 months ago

After further investigation, there appears to be an update that was made that overwrote the fix. What is in Master is currently showing:

    {% if Measure.extension.where(url = 'http://hl7.org/fhir/us/cqfmeasures/StructureDefinition/cqfm-effectiveDataRequirements').exists() %}
        {% for contained in Measure.contained.where(id = 'effective-data-requirements') %}
            <tr>
                <th scope="row"><b>Terminology and Other Dependencies: </b></th>
                <td style="padding-left: 4px;">
                    {% for relatedArtifact in contained.relatedArtifact.where(type = 'depends-on') %}
                        <li>{{relatedArtifact.resource}}</li>
                    {% endfor %}
                </td>
            </tr>
juliet-rubini commented 2 months ago

Stan - I am trying to determine if this tracker is resolved. I am seeing the value set names in the latest MADiE output which was the initial request. Can you confirm if your initial concern is still an issue?

JSRankins commented 2 months ago

@juliet-rubini - not sure what you are looking at, but current export from MADiE shows that Terminology and Other Dependencies row contains canonicals for the value sets but not the names. image

juliet-rubini commented 2 months ago

Ah - I was looking in the data requirements section (where the names are now showing). Thanks for the nudge. I will keep this tracker open so we can get the names added to the Terminology and Other Dependencies section as well.