cqjjjzr / MusicBee-DesktopLyrics

Show the lyrics on your desktop from MusicBee!
Apache License 2.0
92 stars 5 forks source link

fix lrc parse #19

Closed tumuyan closed 9 months ago

tumuyan commented 9 months ago
  1. I find that singleMatch.Groups[3].Value contains a dot, it should be singleMatch.Groups[4].Value

  2. Considering the unregulated lyrics

    [00:55.14]line 1
    [00:55.14]line 2
    [00:55.14]line 3
cqjjjzr commented 9 months ago

As of 2., your version will drop lines after the second line.. Is it really intended? Consider concatenating the lines after 2nd line to the 2nd line maybe?

tumuyan commented 9 months ago

I've thought about what happens when there are more than three lines of lyrics at the same time. The most practical might be the original text, notes, and the translation:

[02:59.06]音楽(おんがく)にありがとう
[02:59.06]ongaku ni arigatou
[02:59.06]永远感谢 这段音乐的人生

But there doesn't seem to be any player that render all three lines at the same time, and also I haven't seen any lrc files like this.

If we concatenating the lines after 2nd line, It's not pretty or easy to read.