cqroot / joplin-outline

A markdown outline (TOC) sidebar plugin for Joplin.
MIT License
215 stars 16 forks source link

Outline does not work correctly when Note Variables plugin is installed #64

Closed petzi53 closed 1 year ago

petzi53 commented 2 years ago

There is a conflict with the Note Variables plugin. With the installation of the Note Variables plugin, your plugin loses its functionality to toggle the visibility of the panel: The Outline panel button (hamburger icon) disappears, and the shortcut F9 does not work anymore.

I have reported the issue to the Note Variables plugin as well.

cqroot commented 2 years ago

I installed the Note Variables plugin, but the problem does not appear.

petzi53 commented 2 years ago

I believe that for replication, you must observe the order of turning on the plugins and if the Outline panel was active the last time. You can't test it anymore with the Notes Variables plugin because it has just released a new version with a complete overhaul, so the problem does not happen anymore.

But I tracked problems of Outline with other plugins as well (Agenda, Convert Text To New Note and Menu Shortcut Toolbar). You can see the problem also in the list of keyboard shortcuts. It says toggleOutline (Invalid). See image.

image

But as I said, tracking the exact problem is complex. Sometimes it works in a certain configuration; many times, it does not.

joochlee commented 2 years ago

I believe that for replication, you must observe the order of turning on the plugins and if the Outline panel was active the last time. You can't test it anymore with the Notes Variables plugin because it has just released a new version with a complete overhaul, so the problem does not happen anymore.

But I tracked problems of Outline with other plugins as well (Agenda, Convert Text To New Note and Menu Shortcut Toolbar). You can see the problem also in the list of keyboard shortcuts. It says toggleOutline (Invalid). See image.

image

But as I said, tracking the exact problem is complex. Sometimes it works in a certain configuration; many times, it does not.

same here, after upgrading to 1.4.1 it does not work anymore. I am using following plugins:

so I downgraded to 1.3.1. 1.3.1 still works

cqroot commented 1 year ago

Does the problem still exist in 1.4.2?

Sorry I still can't reproduce this problem. I tried removing the default keybindings and redundant plugin settings.

joochlee commented 1 year ago

Does the problem still exist in 1.4.2?

Sorry I still can't reproduce this problem. I tried removing the default keybindings and redundant plugin settings.

wow, now it works like a charm! 👍 Thanks, good job !