search

cquery-project / emacs-cquery

Emacs client for cquery, a low-latency language server supporting multi-million line C++ code-bases
116 stars 14 forks source link

font-lock renders unwanted bg color after xref-find-definitions #30

Closed amosbird closed 6 years ago

amosbird commented 6 years ago

This doesn't happen to overlay, however overlay is still extremely slow even with the patch mentioned here https://lists.gnu.org/archive/html/emacs-devel/2018-03/msg00776.html

MaskRay commented 6 years ago

I saw this yesteday. Can you print the text properties?

The font-lock semantic highlighting code

https://github.com/cquery-project/emacs-cquery/blob/master/cquery-semantic-highlighting.el#L280

amosbird commented 6 years ago 
There are text properties here:
  face                 (font-lock-variable-name-face highlight highlight)
  font-lock-face       (font-lock-variable-name-face highlight highlight)
  fontified            t

it's trivial to reproduce. using emacs source code /home/amos/git/emacs/src/xdisp.c:15634 jump to window_height

sebastiencs commented 6 years ago

I think it's a bug in lsp-mode, I made a PR to fix it

amosbird commented 6 years ago

thanks.