cquery-project / emacs-cquery

Emacs client for cquery, a low-latency language server supporting multi-million line C++ code-bases
116 stars 14 forks source link

cquery mess up lsp--execute-command #68

Open yyoncho opened 5 years ago

yyoncho commented 5 years ago

See https://github.com/emacs-lsp/lsp-java/issues/93#issuecomment-456420501

cquery should not add advice on lsp--execute-command but it should use :action-handlers when registering the lsp-client. (or eventually, use the new mechanism with defmethod introduced by @MaskRay in https://github.com/emacs-lsp/lsp-mode/commit/cfde310d8367e9d8fd927d890f26555f9d4325a8) .

@zijianyue