search

cquery-project / vscode-cquery

cquery plugin for Visual Studio Code
54 stars 16 forks source link

Semantic highlighting is messed up #15

Closed HighCommander4 closed 6 years ago

HighCommander4 commented 6 years ago

Some kinds of symbols are colored with the wrong color, as if the symbol kinds got mixed up somehow.

HighCommander4 commented 6 years ago

Looks like the server changed its representation of symbol kinds from ClangSymbolKind to lsSymbolKind, which has slightly different kinds in a different order. Meanwhile the client's SemanticSymbolKind still corresponds to ClangSymbolKind.

MaskRay commented 6 years ago

Yes, ClangSymbolKind has been removed.

https://github.com/cquery-project/emacs-cquery/blob/master/cquery-semantic-highlighting.el#L188 this may help

HighCommander4 commented 6 years ago

I have a fix for this locally, but I will wait until https://github.com/cquery-project/cquery/pull/470 merges, to make sure the changes here correspond to that.

jacobdufault commented 6 years ago

Merged, please upload the PR :)

antcodd commented 6 years ago

Would be nice to get a release for this issue. The inconsistent and missing highlighting is a bit confusing.

MaskRay commented 6 years ago

And $cquery/callTreeInitial -> $cquery/callHierarchyInitial

jacobdufault commented 6 years ago

Would be nice to get a release for this issue. The inconsistent and missing highlighting is a bit confusing.

I've pushed a new release. Make sure to also update the cquery binary, as the call tree / type hierarchy have been renamed to call hierarchy and inheritance hierarchy - the underlying API has changed.

antcodd commented 6 years ago

Thanks! Seems to be working properly.