Open noloader opened 5 years ago
Does branch 'force_aligned' solve your issues? https://github.com/cr-marcstevens/sha1collisiondetection/tree/force_aligned
You will need to add -DSHA1DC_FORCE_ALIGNED_ACCESS
to your compiler options.
@cr-marcstevens Yep, that would fine (and I agree sticking with the FORCE
naming scheme is much clearer than what I showed in the patch above).
We should merge this change back into master. @peff are you ready to take these changes back into Git now?
@shumow Yeah, as soon as this is merged, I can take care of the Git side of things.
@cr-marcstevens I see that there watson checks haven't been run on these changes yet? Has the watson integration been turned off for this branch/project?
Marc, if you're happy with the change, I'm happy to merge it back into master. Of course, pending figuring out what's up with the watson checks.
@shumow I have received emails from TravisCI that both commits in the branch have passed, so TravisCI is still working. But indeed, I also don't see those same confirmations visibly in GitHub.
If everyone is happy then I'll merge it now.
Ahh, yeah -- Travis, not watson. (Can't keep all these proper names straight.) As long as you can confirm it, that's fine.
Thanks for the quick turnaround! The Git patch is at https://public-inbox.org/git/20190312210626.GA5157@sigill.intra.peff.net/.
Per a discussion on Git mailing list at One failed self test on Fedora 29 and assorted follow-ups. The discussion concerns itself with a failed audit due to unaligned accesses in
sha1dc/sha1.c
(usingCFLAGS += -fsanitize=undefined
).And in particular, from Jeff King at [disabling sha1dc unaligned access]():
Please provide an option to disable unaligned accesses.