cr08 / TwitchVault

Simplified tool to automatically download/archive VODs, clips, highlights, including associated chat logs for specified Twitch channels
GNU General Public License v3.0
18 stars 1 forks source link

Migrate from writing placeholder _chat.json.BAD files on failed chat downloads to log file to clean up download folders #2

Closed cr08 closed 1 year ago

cr08 commented 1 year ago

As a workaround for the time being if a chat log is not available (due to either nothing being done in chat for that video or the source VOD is old/unavailable), we write a placeholder _chat.json.BAD file to satisfy future file checks and not attempt downloading again.

This clutters up the download folders with useless files. We do want clean this up and the intent is to write video ID's to a log file as they fail to download and check against this on subsequent passes.

Current non-zero exit code checks for TDCLI are crude. Corner cases such as a Twitch service being unavailable or your own network/ISP issues could cause it to erroneously flag a chat log as failed. Will need examples of TDCLI erroring out in scenarios like these.

cr08 commented 1 year ago

SHOULD be functional in the latest commits. clips.py is confirmed working. videos.py I do not have any suitable videos to test. Please re-open and comment if this is found to not work.