Dump all Data objects as JSON structures

cr0hn / golismero-legacy

THIS IS A LEGACY VERSION PRESERVED FOR BACKUP, DO NOT USE

http://golismero-project.com

15 stars 4 forks source link

Dump all Data objects as JSON structures #204

Closed MarioVilas closed 10 years ago

MarioVilas commented 10 years ago

We have this implemented already. However, we still need to do two things:

1) Test the feature thoroughly, since it's not currently being used anywhere. 2) Make sure this is the design we want, since we'll be using it extensively in the HTML report, JSON report and in the web UI in general.

MarioVilas commented 10 years ago

/cc @rrequero

MarioVilas commented 10 years ago

So far, so good. The key points are:

Don't leave objects or sets in the dictionary, because they can't be encoded to JSON.
The generic output method to_dict() works for most cases, but it's not recursive, so for some classes you have to add a to_dict() method manually.
There can't be a generic from_dict() method, so it has to be done for each class. Currently we don't have any. But for the purposes of tickets #206 and #205 we don't need to either.

MarioVilas commented 10 years ago

Closing after reviewing all Data subclasses, I think they're safe to serialize as JSON now.