search

cr0hn / golismero-legacy

THIS IS A LEGACY VERSION PRESERVED FOR BACKUP, DO NOT USE
http://golismero-project.com
15 stars 4 forks source link

New JSON report plugin #206

Closed MarioVilas closed 10 years ago

MarioVilas commented 10 years ago

This would probably be the foundation of the new HTML report plugin (see ticket #205) since the new template uses JSON to store its data.

Depends on #204.

/cc @rrequero

cr0hn commented 10 years ago

We will work in the new JSON format :)

El 06/12/2013, a las 22:57, Mario Vilas notifications@github.com escribió:

This would probably be the foundation of the new HTML report plugin (see ticket #205) since the new template uses JSON to store its data.

/cc @rrequero @cr0hn

— Reply to this email directly or view it on GitHub.

MarioVilas commented 10 years ago

Take a look at the current format, the idea is to keep it identical to the interface of the Python objects (no point in having two different formats unless we really need to).

MarioVilas commented 10 years ago

Closing since it's working. It'd still be great to have an option to output JSON in a prettier format, or to sort the dictionary keys, etc. but for now the needed functionality is there. And it's supposed to be machine readable anyway. :)

MarioVilas commented 10 years ago

While the structure of each object is the same as the Python object, maybe we should agree on what's the best structure for the JSON output itself.

What we have now is a dictionary with the keys "information", "resource" and "vulnerability", each containing a dictionary mapping Data identity hashes to their contents.

However the HTML template assumes we should have a list of Data objects instead, all mixed up. The identity hashes are missing too, so I presume they wouldn't be used. I think there's also a "target" property that identifies to what resource does the vulnerability apply. Any other data type is also missing, so information like IP geolocation, port scans or traceroutes won't show up in the report, I suppose.

I'm concerned because the HTML report looks great, but maybe hasn't been developed with the proper data structures in mind? :(

rrequero commented 10 years ago

Cr0hn and I talked about a possible format so that I could be working on the report, but the json there right now in the report is not the final format. No problem in json format change since the report can be adapted to any format with some minimal changes. When decided the final format of json, I adapt :)

Raúl Visita www.rrequero.com

2013/12/7 Mario Vilas notifications@github.com

While the structure of each object is the same as the Python object, maybe we should agree on what's the best structure for the JSON output itself.

What we have now is a dictionary with the keys "information", "resource" and "vulnerability", each containing a dictionary mapping Data identity hashes to their contents.

However the HTML template assumes we should have a list of Data objects instead, all mixed up. The identity hashes are missing too, so I presume they wouldn't be used. I think there's also a "target" property that identifies to what resource does the vulnerability apply. Any other data type is also missing, so information like IP geolocation, port scans or traceroutes won't show up in the report, I suppose.

I'm concerned because the HTML report looks great, but maybe hasn't been developed with the proper data structures in mind? :(

— Reply to this email directly or view it on GitHubhttps://github.com/cr0hn/golismero/issues/206#issuecomment-30057857 .

MarioVilas commented 10 years ago

Awesome :D

We'll need a real-life meeting so I can know more about the HTML report and you can know more about the data model. With @cr0hn we call this "reunicañas" ;)