cr4ckp0t / AnnounceRare

Announce rares to general chat of Nazjatar and Mechagon.
MIT License
4 stars 6 forks source link

11.0.2 Breaks Announce Rare #55

Open karpana opened 2 months ago

karpana commented 2 months ago

AnnounceRare is now generatging this error on startup:

24x AnnounceRare/AnnounceRare.lua:45: attempt to call local 'GetAddOnMetadata' (a nil value)
[string "@AnnounceRare/AnnounceRare.lua"]:45: in main chunk

Locals:
AR = <table> {
 modules = <table> {
 }
 defaultModuleLibraries = <table> {
 }
 name = "AnnounceRare"
 orderedModules = <table> {
 }
 hooks = <table> {
 }
 enabledState = true
 defaultModuleState = true
}
L = <table> {
 Target does not meet criteria to be announced. = "Target does not meet criteria to be announced."
 Cache = "Cache"
 Display configuration window. = "Display configuration window."
 Earthbreaker Gulroc = "Earthbreaker Gulroc"
 Chat Link = "Chat Link"
 Raid = "Raid"
 %s has already been announced. = "%s has already been announced."
 |cffff7d0a%s:|r %s = "|cffff7d0a%s:|r %s"
 Relic Crate = "Relic Crate"
 Notification Method = "Notification Method"
 %s%s (%s/%s %.2f%%) is at %s %s%s and %s = "%s%s (%s/%s %.2f%%) is at %s %s%s and %s"
 Print target information. = "Print target information."
 Enable this to assist with fixing a bug or unintended functionality. = "Enable this to assist with fixing a bug or unintended functionality."
 %sArmory is located at %s, %s! = "%sArmory is located at %s, %s!"
 AR2 Log = "AR2 Log"
 Officer = "Officer"
 Valid NPC = "Valid NPC"
 Boilburn = "Boilburn"
 Announce rare to output channel. = "Announce rare to output channel."
 General Options = "General Options"
 Displaying configuration options. = "Displaying configuration options."
 Caustic Mechaslime = "Caustic Mechaslime"
 General Chat = "General Chat"
 %s%s (%s/%s %.2f%%) %.2f %.2f %s = "%s%s (%s/%s %.2f%%) %.2f %.2f %s"
 Button = "Button"
 Toggle addon debugging. = "Toggle addon debugging."
 Unable to determine target's ID. = "Unable to determine target's ID."
 Channel Output = "Channel Output"
 %s (%s) is up at %s %s. = "%s (%s) is up at %s %s."
 Ol' Big Tusk = "Ol' Big Tusk"
 You cannot announce a dead rare's position. = "You cannot announce a dead rare's position."
 Announce spectral key location. = "Announce spectral key location."
 Version = "Version"
 Say = "Say"
 Broken = "Broken"
 ENABLED = "ENABLED"
 Gemicide = "Gemicide"
 Print zone information. = "Print zone information."
 Guild = "Guild"
 Print some help. = "Print some help."
 Party = "Party"
 Announce cache location. = "Announce cache location."
 Zone ID: = "Zone ID:"
 Announcement Options = "Announcement Options"
 Display a loading message when the addon first loads. = "Display a loading message when the addon first loads."
 Unable to determine the NPC's GUID. = "Unable to determine the NPC's GUID."
 Yell = "Yell"
 Active Teleporter = "Active Teleporter"
 Has Entry = "Has Entry"
 Announcing Rare Death: %s = "Announcing Rare Death: %s"
 Drill Announcements = "Drill Announcements"
 Unable to determine your general channel number. = "Unable to determine your general channel number."
 Unable to determine %s's ID. = "Unable to determine %s's ID."
 AnnounceRare v%s loaded! Please use |cffffff00/rare help|r for commands. = "AnnounceRare v%s loaded! Please use |cffffff00/rare help|r for commands."
 TomTom Waypoints = "TomTom Waypoints"
 %s at %s, %s! %s = "%s at %s, %s! %s"
 Adds a prefix to chat messages with the name of the addon. = "Adds a prefix to chat messages with the name of the addon."
 Debugging must be enabled to use this command. = "Debugging must be enabled to use this command."
 Announce drill sites to let people know what mob is about to be available. = "Announce drill sites to let people know what mob is about to be available."
 Time Displacement = "Time Displacement"
 Spectral Tear = "Spectral Tear"
 The Kleptoboss = "The Kleptoboss"
 Spectral Key = "Spectral Key"
 Command Line Help = "Command Line Help"
 Channel to send the messages to. = "Channel to send the messages to."
 Monitor chat for rare notifications and create TomTom waypoints for them. = "Monitor chat for rare notifications and create TomTom waypoints for them."
 You must have TomTom installed to use waypoints. = "You must have TomTom installed to use waypoints."
 Skipping print due to throttle. = "Skipping print due to throttle."
 Debugging has been %s! = "Debugging has been %s!"
 Loading Message = "Loading Message"
 Chat link skipped due to target being dead. = "Chat link skipped due to ta
karpana commented 2 months ago

adding this line of code at line 45 fixes the above error

local GetAddOnMetadata = C_AddOns and C_AddOns.GetAddOnMetadata or GetAddOnMetadata

but causes another error to be exposed:

1x AnnounceRare/AnnounceRare.lua:756: attempt to call upvalue 'IsAddOnLoaded' (a nil value)
[string "@AnnounceRare/AnnounceRare.lua"]:756: in function `?'
[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:109: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:109>
[string "=[C]"]: ?
[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@TomTom/libs/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <...aceTomTom/libs/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals:
self = <table> {
 modules = <table> {
 }
 linkCooldown = 15
 debug = false
 correctZone = true
 defaultModuleState = true
 optionsUI = Frame {
 }
 db = <table> {
 }
 enabledState = true
 zoneText = "nazjatar"
 defaultModuleLibraries = <table> {
 }
 baseName = "AnnounceRare"
 version = "3.6.2"
 orderedModules = <table> {
 }
 mouseCooldown = 30
 rares = <table> {
 }
 zones = <table> {
 }
 cooldown = 180
 name = "AnnounceRare"
 title = "Announce Rare"
 hooks = <table> {
 }
}
(*temporary) = nil
(*temporary) = "TomTom"
(*temporary) = "attempt to call upvalue 'IsAddOnLoaded' (a nil value)"
IsAddOnLoaded = nil
L = <table> {
 Target does not meet criteria to be announced. = "Target does not meet criteria to be announced."
 Cache = "Cache"
 Display configuration window. = "Display configuration window."
 Earthbreaker Gulroc = "Earthbreaker Gulroc"
 Chat Link = "Chat Link"
 Raid = "Raid"
 %s has already been announced. = "%s has already been announced."
 |cffff7d0a%s:|r %s = "|cffff7d0a%s:|r %s"
 Relic Crate = "Relic Crate"
 Notification Method = "Notification Method"
 %s%s (%s/%s %.2f%%) is at %s %s%s and %s = "%s%s (%s/%s %.2f%%) is at %s %s%s and %s"
 Print target information. = "Print target information."
 Enable this to assist with fixing a bug or unintended functionality. = "Enable this to assist with fixing a bug or unintended functionality."
 %sArmory is located at %s, %s! = "%sArmory is located at %s, %s!"
 AR2 Log = "AR2 Log"
 Officer = "Officer"
 Valid NPC = "Valid NPC"
 Boilburn = "Boilburn"
 Announce rare to output channel. = "Announce rare to output channel."
 Automatically create TomTom waypoints for you when a drill site is activated.

|cffff0000REQUIRES TOMTOM ADDON!|r = "Automatically create TomTom waypoints for you when a drill site is activated.

|cffff0000REQUIRES TOMTOM ADDON!|r"
 General Options = "General Options"
 Displaying configuration options. = "Displaying configuration options."
 Caustic Mechaslime = "Caustic Mechaslime"
 General Chat = "General Chat"
 %s%s (%s/%s %.2f%%) %.2f %.2f %s = "%s%s (%s/%s %.2f%%) %.2f %.2f %s"
 Button = "Button"
 Toggle addon debugging. = "Toggle addon debugging."
 Unable to determine target's ID. = "Unable to determine target's ID."
 Channel Output = "Channel Output"
 %s (%s) is up at %s %s. = "%s (%s) is up at %s %s."
 Ol' Big Tusk = "Ol' Big Tusk"
 You cannot announce a dead rare's position. = "You cannot announce a dead rare's position."
 Announce spectral key location. = "Announce spectral key location."
 Version = "Version"
 Say = "Say"
 Broken = "Broken"
 ENABLED = "ENABLED"
 Gemicide = "Gemicide"
 Print zone information. = "Print zone information."
 Guild = "Guild"
 Print some help. = "Print some help."
 How do you want to be notified of a rare?

Chat Link (Default) - Prints a link in your default chat frame that you click to send the announcement.
Button - A button will appear when you target a rare to send the announcement. = "How do you want to be notified of a rare?

Chat Link (Default) - Prints a link in your default chat frame that you click to send the announcement.
Button - A button will appear when you target a rare to send the announcement."
 Party = "Party"
 Announce cache location. = "Announce cache location."
 AR = "AR"
 Beginning in WOW patch 8.2.5 the API function |cffffff00SendChatMessage|r is now a protected. This essentially means that user input is required to trigger the chat message, otherwise you will receive an "ADDON_ACTION_BLOCKED" error you may have seen with previous versions of AR. = "Beginning in WOW patch 8.2.5 the API function |cffffff00SendChatMessage|r is now a protected. This essentially means that user input is required to trigger the chat message, otherwise you will receive an "ADDON_ACTION_BLOCKED" error you may have seen with previous versions of AR."
 Zone ID: = "Zone ID:"
 Announcement Options = "Announcement Options"
 Display a loading message when the addon first loads. = "Display a loading message when the addon first loads."
 Unable to determine the NPC's GUID. = "Unable to determine the NPC's GUID."
 Yell = "Yell"
 Acti
karpana commented 2 months ago

the second error can be fixed by adding this line of code at 756 just before the call to isAddonLoaded

local IsAddOnLoaded = C_AddOns.IsAddOnLoaded or IsAddOnLoaded;
Sillysith commented 2 months ago

can we get an update/fix please?