search

crabber-net / crabber

A Twitter clone written in Python + Flask with extended features and a focus on inclusivity.
https://crabber.net
GNU General Public License v2.0
48 stars 16 forks source link

Text not being cleared from text boxes (minor issue) #95

Open viiuan opened 3 years ago

viiuan commented 3 years ago

Describe the bug Text written for a quote remolt/reply stays in the text box after posting + going to quote remolt/reply to something else

To Reproduce

  1. Remolt/reply to a molt
  2. Remolt/reply to another molt It depends on which action you try again, but the text "sticks"

Expected behavior The textbox to be clear when starting a new quote molt or reply

Desktop (please complete the following information):

hqnna commented 3 years ago

It took me a while to be able to find how to reproduce this, on my end this was only reproducible when you close out the reply/molt modal without actually posting it, if you actually post (which causes the page to refresh) the content of the modal is cleared.

jakeledoux commented 3 years ago

Which is intended behaviour, no? I've deliberately closed the modal to read the original post more before finishing my reply.

When we switch the modals to Ajax then we'll want to clear them upon submit but it will effectively work the same way as it does now.

hqnna commented 3 years ago

Yeah i don't think this is a bug, rather just intended behavior

viiuan commented 3 years ago

on my end this was only reproducible when you close out the reply/molt modal without actually posting it on my end it also happened after posting when doing the same action on a new molt, which is why i brought it here, but then I wonder why that'd happen to me

hqnna commented 3 years ago

Strange as I tried multiple times to reproduce it and couldn't, could be a browser specific bug

jakeledoux commented 3 years ago

I've gone to bed already but I just wanted to chime in to say that most of these "hard to reproduce" bugs tend to be caused by the order of ajax page loads. For instance: directly navigating to /wild-west and then ajax loading /notifications was the cause of one of the bugs I fixed earlier today.

Hope that helps you track it down.

viiuan commented 3 years ago

i just realized it could also be maybe like, navigating back a page using my browser buttons rather than the in-site one

jakeledoux commented 3 years ago

Ohh you might be right. Sometimes it uses the cached HTML which includes the modal contents (and sometimes the button will say "Submitting...")

hqnna commented 3 years ago

If this is still an issue I can look into it later today.