search

crabbly / Print.js

A tiny javascript library to help printing from the web.
MIT License
4.32k stars 674 forks source link

Fixing #582 and #572 #587

Closed PauloPeres closed 1 year ago

PauloPeres commented 3 years ago

With this pull request I'm Fixing Issue #582 and #572 Also it's a improvement from the PR #566

Added another parameter frameRemoveDelay Default value is Null so it will not change to anyone else. But when it's needed is there to add a little bit more time to print when using silent printing --kiosk-printing on Chromium based browsers.

Added a testing button and did the test my self using 1000ms and it worked.

kimaguri commented 3 years ago

please, merge this PR

PauloPeres commented 3 years ago

Whoever is waiting for this PR you can use "print-js": "git+https://github.com/PauloPeres/Print.js.git#production", on your Package json, replacing the print-js for this github repo

stoufax commented 2 years ago

any new update about this pr

joeknex commented 2 years ago

@crabbly Can this be pulled please?

PauloPeres commented 1 year ago

Can a New Release be published on NPM ?

yoshiko-pg commented 1 year ago

I too am waiting for the release of a new version in npm! @crabbly

yoshiko-pg commented 1 year ago

@crabbly Is there something wrong with releasing a new version to npm?