Fix PDF printing in Firefox version >= 110

crabbly / Print.js

A tiny javascript library to help printing from the web.

MIT License

4.28k stars 672 forks source link

Fix PDF printing in Firefox version >= 110 #657

Closed amoilanen closed 1 year ago

amoilanen commented 1 year ago

Fixes the issue https://github.com/crabbly/Print.js/issues/655
Side-effect: speeds up printing in Firefox >= 110 since the wait of 1000 milliseconds is no longer required

Changes

Add getFirefoxMajorVersion function to the Browser module (another alternative would be to use sniffr, but thought not to add an extra dependency)
Apply the Firefox-specific workarounds in the Print module only for Firefox major versions < 110

Testing

Tested the changes using test/manual/index.html on a Linux machine with Firefox 110.0 and Chrome 109.0.5414.74

LukasKlement commented 1 year ago

This fix is critical to support the latest version of Firefox. Without this PR, the library looses most of its raison d'être. Please merge and release a new version asap 🙏

ZakiMohammed commented 1 year ago

@crabbly Please review and once approved, please merge this PR asap 🙏

ZakiMohammed commented 1 year ago

@crabbly please help me understand, when we are expecting these changes in next release? What will be the date of next release?

Gildedter commented 1 year ago

Waiting for the release, I was wondering why it broke, was it cause by updating my Firefox?

LukasKlement commented 1 year ago

@Gildedter yes, it is a change in Firefox v110, which is now working more similar to other browser engines (Webkit + Blink). All in all, a good thing. Thanks @amoilanen for the PR and @crabbly for merging it. @crabbly could you please release a new version on npmjs 🙏 ?