search

crabdancing / nixpak-flatpak-wrapper

Hacks helping with semi-almost-usable declarative NixOS sandboxing
GNU Lesser General Public License v3.0
9 stars 1 forks source link

Module: Use services.flatpak.package to override binary #5

Closed networkException closed 3 months ago

networkException commented 3 months ago

Instead of adding the wrapper package to environment.systemPackages and the likes ourselves, we now use the services.flatpak.package option.

Depends on https://github.com/NixOS/nixpkgs/pull/331993 Supercedes #4

crabdancing commented 3 months ago

Looks great! I'll try it out on my machine later today, and merge if working without issue. Thank you for contributing! :D

networkException commented 3 months ago

The module change has landed in stable and unstable now :)

crabdancing commented 3 months ago

sorry I haven't been able to test this lately. I caught COVID 19 recently and am still recovering. I'll probably be able to do it in a few days.

networkException commented 3 months ago

oh shit, I hope you get better soon!

crabdancing commented 3 months ago

No worries, I'm well on my way to recovery.

Your PR worked great in my test, and is merged now. ^w^ Thanks for your contribution!