Add handling of unimplemented points

crabmusket / gosunspec

SunSpec domain model and use cases for Go. UNMAINTAINED

BSD 3-Clause "New" or "Revised" License

2 stars 6 forks source link

Closed andig closed 4 years ago

andig commented 5 years ago

Fixes #33.

BC break as behaviour changes. Might make sense to only apply this to ScaledValue instead of Value, too to limit the impact.

Open:

jonseymour commented 5 years ago

Please rebase onto master. I need to think about this one some more.

andig commented 5 years ago

Done. It think we need to decide:

does this need a type or is nil sufficient
where does this need to be implemented- all getters or value and/or scaled value
or an outside helper function instead part of the point
if this should also catch the acc type fields which I've skipped

andig commented 5 years ago

ping @jonseymour anything I could do at this time?

andig commented 5 years ago

Ping @jonseymour could we take this further? I really appreciate the exchange- would be great to keep it up!