search

crabmusket / gosunspec

SunSpec domain model and use cases for Go. UNMAINTAINED
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Fix test case for 8 byte eui48 #43

Closed andig closed 4 years ago

andig commented 5 years ago

This is required as the first 2 bytes are ignored. It becomes obvious that the 8 byte implementation in #39 has its drawback. While it can serialize/inserialize without loss of the first word, clients using it need to adjust semantics.

To avoid client-side interpretation of the sunspec spec #41 helps to lessen the pain.

For time being this corrects the change but we may need to revisit the design decision.

andig commented 5 years ago

ping @jonseymour ready to take this further? What would you think about adding travis ci?