search

crabnebula-dev / cargo-packager

Rust executable packager, bundler and updater.
https://docs.crabnebula.dev/packager/
Apache License 2.0
241 stars 16 forks source link

Feature request: allow non semver version #247

Open wiiznokes opened 3 months ago

wiiznokes commented 3 months ago

At least document on the version config field that semver compatible version is required. I know it will get tricky for the update feature, so i understand if this is not implemented. I just lost some time migrating my project to another version format for nothing

amr-crabnebula commented 3 months ago

I think we can add support for non-semver version, we already have a version_comparator function in the updater, we will just need to change its signature to take String instead of semver::Version.

amr-crabnebula commented 3 months ago

I am curious though, where exactly did you face issues with sermver, during packaging? which packaging format? or during updating?

wiiznokes commented 3 months ago

During packaging for nsis. I finally found a workarround, by using YYYY.MM.0 format. This way, the update should also works if i implement it.