Closed alve-crabnebula closed 7 months ago
Name | Link |
---|---|
Latest commit | d2258d6032489c23c6ccb6fd340b33b2145f4b37 |
Latest deploy log | https://app.netlify.com/sites/cn-devtools-app/deploys/660bf83308975900084b53f5 |
Deploy Preview | https://deploy-preview-256--cn-devtools-app.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I have 3 little nitpicks on it I'd love your opinion on:
Though it doesn't mess up usability, it is a bit distracting (imho) and doesn't really look great. Our UI is busy as it is, so I'm not sure I have a better solution. The green circle on the top right was very confusing with the Mac window buttons as well.
?
that, to me, was successful in implying a tooltip would show up on hover, since that's a common pattern.Tauri Config
tab to just Config
. I really liked that idea, since we only work for Tauri right now (and anytime that tab is an option, it will be in the context of connected to an app. I think "Tauri Config" is redundant, specially with the icon. So I really liked the idea of naming it "Config" π@atila-crabnebula
I do see what you mean about inlay hints. This "Connected" status is just a reminder though - we show people a modal when they are disconnected and it's kind of "in your face". We made a proposal for making that a little softer, but the user flow is still that they will know when they are disconnected. And the inlay hints don't show up very often - just when a user is attempting something else.
I don't know anything about this change. Maybe @alve-crabnebula can chime in here.
When shortening some names and then also realizing that we may need a "Settings" page at some point, we thought it was important to add that context back in. Icons are helpful, but are not actually part of the title - someone may not recognize it or even see it clearly. In the future as we build support for other frameworks or app types, the tab content would be very different and the tab name can reflect it.
The icon on the right of Tauri Configs doesn't tell me much. As a matter of fact, it's a bit far and before the key, which suggests me it will do something, but it doesn't. I think this is a step back from the small ? that, to me, was successful in implying a tooltip would show up on hover, since that's a common pattern.
So, I didn't get to fully complete the changes I wanted to do in the Tauri Configs tab, so a bit of a work in progress, I could do that as a separate PR
This PR is inspired by the design crit I and @parker-crabnebula did today
Changes;
Suggestions (Diden't have time to fix):