crabnuggets / pe

0 stars 0 forks source link

Possible missing activation bar for `SignInDetailsParser` #8

Open crabnuggets opened 2 years ago

crabnuggets commented 2 years ago

In page 22 of the DG, SignInDetailsParser seems to be missing its own activation bar.

image.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Sequence Diagram does not have activation bar for SignInDetailsParser

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


As seen below, there is a missing activation bar for SignInDetailsParser, which is not compliant with the notation learnt in CS2113/T. Which method is calling the methods getNewSalt(), generatePasswordHash(), etc.? Only the activation bar for the self-invocation (checkUserRole()) is shown.

image.png


[original: nus-cs2113-AY2122S1/pe-interim#60] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This actually follows the notation for reference frames shown on the module website.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]