search

crabnuggets / pe

0 stars 0 forks source link

Possible missing return arrows for `Logging in` sequence diagram #9

Open crabnuggets opened 2 years ago

crabnuggets commented 2 years ago

There seem to be potential missing dotted line arrows for the sequence diagram for Logging in. Even though the method calls might return void, it seems like VerificationUi should have a dotted-line returning back to :Login for each method call made by :Login.

image.png

Similarly, dotted line arrows from :Verifier to :Login seem to be missing after each Set method call by :Login in the alt block.

image.png

nus-pe-script commented 2 years ago

Team's Response

According to the module website,

image.png

the return arrows in these diagrams were omitted to reduce clutter. We had actually considered adding the arrows but the diagram turned out to be very messy. Furthermore, the removal of these arrows does not lead to any loss of information/ambiguity.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]