search

crabvk / bar-gmail

A Polybar module to show unread messages from Gmail
MIT License
90 stars 12 forks source link

Fix coloring of the text in polybar format #34

Closed mark2185 closed 9 months ago

mark2185 commented 1 year ago

Only the badge should be colored, as the preview in README.md shows, but currently both the badge and the count are colored.

crabvk commented 1 year ago

The preview is outdated.

mark2185 commented 1 year ago

That may be the case, but the coloring did change in https://github.com/crabvk/bar-gmail/commit/22e7535aa253d54a5ee7a554c835aa3e087475b9 so this keeps it consistent with how it was before.

crabvk commented 1 year ago

I thought about preserving the same behaviour/coloring for Polybar, but in output for Waybar there's CSS class added to the whole text (badge + messages count), i.e. color can be changed only for the whole. So the coloring is consistent in this way.

mark2185 commented 1 year ago

Fair enough, both approaches make sense.

I'm okay with having a fork for this since I'm used to only the icon being colored.