search

crabvk / notify-call

Command-line tool to send desktop notifications and handle actions
MIT License
4 stars 1 forks source link

Notification urgency should be specified as byte, not i32. #1

Open Toqozz opened 3 years ago

Toqozz commented 3 years ago

The desktop notifications spec says that the urgency hint should be of type byte, but it seems to be pushing an i32: https://github.com/crabvk/notify-call/blob/de954671d21ba684b59b433c5b98439644e6eba6/src/main.rs#L67

This is probably solved by just casting as u8 instead.

I'm not sure if this is the case in general, but my notification daemon won't pick up the urgency hint from notify-call because it's trying to grab a byte (u8) and gets an i32 instead. I suspect this is true for dunst as well: https://github.com/dunst-project/dunst/blob/cf091bea37c2567d63a45ee6e1e0d07cbd6e7ff3/src/dbus.c#L370

crabvk commented 3 years ago

Thank you for reporting the issue, it should be fixed now.