Default document vector creation broken in version 1.17

crack521 / semanticvectors

Automatically exported from code.google.com/p/semanticvectors

Other

1 stars 0 forks source link

Default document vector creation broken in version 1.17 #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Apparently revision 209 that fixed bug 9 also broke default document vector
creation. Must fix.

Original issue reported on code.google.com by dwidd...@gmail.com on 20 Jan 2009 at 8:30

GoogleCodeExporter commented 9 years ago

It turns out that the problem was caused by adding the clone() statement to 
getVector
in VectorStoreRAM. I've reverted this change ... but this still leaves the 
problem of
trying to figure out why CompareTerms gives different results after a while ...

Original comment by dwidd...@gmail.com on 21 Jan 2009 at 9:12

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Just to followup, the empty DocVector problem looks like it was because 
DocVectors
deliberately builds DocVectors in place as an optimization, which I'd be loathe 
to
give up. We need unit tests!

Original comment by dwidd...@gmail.com on 22 Jan 2009 at 4:59