search

crackededed / Xtra

Xtra is a Twitch player and browser for Android.
GNU Affero General Public License v3.0
1.25k stars 48 forks source link

[Improvement] Save VODs positions in more cases #171

Open LukasThyWalls opened 2 years ago

LukasThyWalls commented 2 years ago

Hello.

I was using Xtra for a while and always had an issue with the VODs saved positions. Sometimes it didn't save the position at all, but i never figured out why sometimes it does and sometimes it doesn't, and if i do something different at those occasions.

What i saw in all this time is how i think it does: When you swipe out a video in PiP mode inside and (i think) outside the app, it save the position. If you pause the video, go to PiP mode, and swipe out it, it save the positions when you swipe out, not when you pause it. That's important because if instead of swipe out the video, you go to other video, it doesn't save the position for the first one.

I don't know in what cases it should be doing, but that's what i see it's doing right now.

So, the improvement there is to save the position in more cases: For example, when you pause a video, when you change it to other one, be sure to do it when you exit the app and there is a video playing. Also could be good to save positions automatically, maybe every few minutes or so, and avoid issues when the app crash for other reasons ( #123 ) although i don't know if it's feasible.

Thanks!

EvilGremlin commented 10 months ago

Can confirm, exact same behavior, still no fix. Background with screen off is comletely unusable, if i pause from headset and wont resume in next minute or two, it can't be resumed anymore at all and lose position. Both for online and saved video.