search

crackededed / Xtra

Xtra is a Twitch player and browser for Android.
GNU Affero General Public License v3.0
1.23k stars 47 forks source link

Default Closed Captions Button Visibility Toggle to On #335

Open viscountexx opened 1 year ago

viscountexx commented 1 year ago

Closed captions being hidden away in a menu is a major accessibility issue. The menus are complex and I expect the defaults to be that "extraneous" or "annoying" buttons like follow (which i can access outside the player anyway) are turned off but standardized accessibility features that are an option on literally every single TV/media device should be shown by default.

(Edit to clarify: I would like the button to be visible by default, not captions to be on by default.)

I didn't even know this option existed until checking GitHub.

thinkpad4 commented 1 year ago

Edited. So not to distract from the open ticket

viscountexx commented 1 year ago

Make the option easier to find but do not make it default on

Why?

thinkpad4 commented 1 year ago

Edited. So not to distract from the open ticket. @mindmeshlink Edited my previous comments since the misunderstanding got cleared up

viscountexx commented 1 year ago

The closed captions wouldn't be on by default. The button would show up in the UI by default. Which is how it is already on Youtube and the official Twitch app. Edited the issue to make that clearer.

thinkpad4 commented 1 year ago

@mindmeshlink That makes SO much more sense. Totally agree that the option should be visible by default.

crackededed commented 1 year ago

currently the player can't detect if the video has captions or not so the button is always forced to be visible with this setting on. so most of the time you have a button that does nothing. maybe it would be better to have this setting visible in the player menu by default. also chunkless preparation is disabled to force the captions to work. this increases start up time for the player. i think it should only be a few seconds at most but maybe it causes problems for older devices. so i don't really want to disable that by default. maybe the playlist could be modified instead to enable the captions and then that would not be a problem.