cracker0dks / whiteboard

Lightweight collaborative Whiteboard / Sketchboard
MIT License
719 stars 198 forks source link

Feature/signature pad #136

Closed shooding closed 1 year ago

shooding commented 2 years ago

add signature pad feature from github.com/szimek/signature_pad and rewritten in whiteboard style. Enable font awesome icon for signature signing pad. Signature can be downloaded for later usage or draw to canvas with current imgWithSrc method.

After window resized, the signature canvas needs to be resized as well to make sure gesture and mouse click start from the same position.

_this.signaturePad.clear(); may not be necessary each time window resized.

cracker0dks commented 2 years ago

Hey, thanks for your PR, I like the feature but it would be even better if we could draw on the maincanvas. I have not looked into the bib yet but do you think this would be possible with reasonable effort? Or is there a reason it is seperated atm?

shooding commented 2 years ago

Yes, it would be best to draw on the same canvas so that the gesture can sync to all others. Actually i have completed that version with dynamic width which looks great around 2.5 to 5 in width, but not satisfied enough with current curve interpolation function.

I think the seperate signing panel is still quite useful as an option for those user only want to upload a satisfying signature instead of sign & undo & sign & undo in realtime.

Cracker @.***> 於 2022年2月8日 週二 下午6:39 寫道:

Hey, thanks for your PR, I like the feature but it would be even better if we could draw on the maincanvas. I have not looked into the bib yet but do you think this would be possible with reasonable effort? Or is there a reason it is seperated atm?

— Reply to this email directly, view it on GitHub https://github.com/cracker0dks/whiteboard/pull/136#issuecomment-1032462129, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQKSNWAAJV5AI6D7BWDFNLU2DXHXANCNFSM5NZQFFQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

cracker0dks commented 2 years ago

Do you have an unscase where you have to sign on a whiteboard? I just find the drawing style very nice :)

shooding commented 2 years ago

I do have a banking use case KYC (know your customer) requires customer sign contract and record the gesture in a video conference.

Cracker @.***> 於 2022年2月8日 週二 下午8:50 寫道:

Do you have an unscase where you have to sign on a whiteboard? I just find the drawing style very nice :)

— Reply to this email directly, view it on GitHub https://github.com/cracker0dks/whiteboard/pull/136#issuecomment-1032573678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQKSNQ2NXLHDJLZENK4GEDU2EGRJANCNFSM5NZQFFQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

cracker0dks commented 2 years ago

ok, got it. Because this is a "niche" featrue, I think it's best if we put it optional, so you can enable it via config (Like the WebDav feature). I can implement that if you want?