search

craeyeons / pe

0 stars 0 forks source link

Error Message doesn't match invalid input #5

Open craeyeons opened 1 year ago

craeyeons commented 1 year ago

image.png

Steps to reproduce:

  1. execute add task "Merge PR" -a 1 2022-12-02- 23:59

I feel that the command should not be blocked, and the more appropriate error message should tell me that i left out the "-d" tag.

nus-pe-bot commented 1 year ago

Team's Response

Thank you for the suggestion!

However, we feel that the current error message is quite accurate because it prompts the user to try running the add task --help command, which will show the exact format for all flags and parameters. Running the add task --help command gives the message as shown in the screenshot below, which guides users to use the -d flag in their input.

Once again, thank you and have a good reading week ahead :)

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: As a user, it makes little sense as to why one should

  1. delete their entire line of command

  2. add task --help

  3. then manually check their input to know that they have left out a field called "-d"

This is overzealous blocking of inputs. It would be nice if at least an appropriate error message telling the user what is being left out/forgotten is given.

image.png