search

craeyeons / pe

0 stars 0 forks source link

Sort Task does not sort in alphabetical order. #6

Open craeyeons opened 1 year ago

craeyeons commented 1 year ago

image.png

Steps to reproduce:

  1. execute sort tasks asc

Note that "create pr" is under "Merge PR".

Similarly, it does not sort in alphabetical order for sort tasks dsc as well.

Attached below is a screenshot for sort tasks dsc

image.png

soc-pe-bot commented 1 year ago

Team's Response

Fixing the UG to include that sorting of members and tasks is case sensitive fixes this issue as well.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Sort Members does not sort in alphabetical order (dsc).

image.png

Steps to reproduce:

  1. execute sort m dsc

Observe that joebob is ahead of David Li.

[original: nus-cs2103-AY2223S1/pe-interim#4345] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi, thanks for the bug report!

Your observation is correct that our application does not sort the members or tasks by alphabetical order in the traditional sense. However, it is not a functionality bug. We instead perform case-sensitive sorting. Observe that since joebob begins with a lower-case j, it has a higher ASCII value than all the upper-case characters.

We accept that it might be confusing since this is not clearly mentioned in the User Guide. In particular, the UG mentions that members and tasks are sorted alphabetically (but misses the keyword case-sensitive) Hence, we're shifting the bug type to documentation bug. (Note that this is not very different from alphabetical sorting since within the same category of case, the ASCII values follow an alphabetical ordering.)

Regarding the severity, since our target user is a software engineering team lead (who is probably familiar with case-sensitive sorting), we do not expect this to be a major inconvenience. In the rare occasions that the user uses different cases for different members, this causes minor inconvenience since this behaviour is not clearly communicated in the UG. Following the module website's severity classification for such issues means that it is a low severity bug.

Hope you understand our rationale.

Thanks and have a nice reading week ahead!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: SortMembers and SortTask is sorting for 2 different features and have to be considered separately. At most only the SortMembers part should be considered same, for which I apologise for making the same bug report twice.

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: 1. It hinders the productivity of a team lead a lot. It is unrealistic to expect the team lead to remember if he typed "Create PR" or "create PR" only to be forced to look for the task twice in the list.

  1. I really don't think this is a Documentation Bug, it makes little sense to me as to why you would like to sort case-sensitive. By default, any user would assume this feature to sort AaBb...Zz.

image.png

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: As explained in the previous part. It is defeats the purpose of sorting when it makes one look twice in the list. e.g in both cases (C and c).