search

craeyeons / pe

0 stars 0 forks source link

Names with a spacing. #7

Open craeyeons opened 1 year ago

craeyeons commented 1 year ago

image.png

The error message of when adding names with multiple words should tell the user to include " ". Not to say "Invalid Command Format". It forces the user to check his/her own command rather than add " ".

Steps to reproduce:

  1. execute add l -n google images -l googleimages.com
nus-pe-script commented 1 year ago

Team's Response

Hi, thanks for the report! We acknowledge this is a bug, but unfortunately we believe it is out of scope for v1.4

With reference to the CS2103T website:

image.png

In this case, detecting when it is an invalid command (e.g. invalid flag) vs a case of missing quotes requires extra parsing logic that would not be allowed in v1.4 (this is also explained in our user guide in the included screenshot below).

image.png

Based on the above, we have marked this as NotInScope. Hope you understand our rationale!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: My complaint is that the error message is not specific enough as mentioned in the first screenshot of yours. Hence, I do not understand what is out of scope here.

image.png

Clearly, what I have presented was a case of invalid value (name with spaces, but without quotes). However, the error message received was invalid format. Hence I disagree and think that this is indeed within scope, and is of low severity.

(this is also explained in our user guide in the included screenshot below).

Unfortunately this has nothing to do with the user guide. The focus here in on the error message itself.

detecting when it is an invalid command (e.g. invalid flag) vs a case of missing quotes requires extra parsing logic that would not be allowed in v1.4

I am sure you could have implemented it in v1.4. See FAQ:

image.png

  1. I do not think that whether if you could have implemented in v1.4 is part of the responsibility of the tester.

  2. I believe detecting a whitespace or quotes before the next flag is not difficult since each flag starts either with "-" or "--". Hence, I do not think this requires a "separate logic"