search

craffel / mir_eval

Evaluation functions for music/audio information retrieval/signal processing algorithms.
MIT License
604 stars 112 forks source link

matplotlib 2.0 may break regression tests on display module #233

Closed bmcfee closed 7 years ago

bmcfee commented 7 years ago

Just putting this issue here, since the new release might change some of the default settings in ways that cause the regression tests to fail.

My advice is to update the build requirements for testing to matplotlib >= 2.0.0 and re-generate the test cases accordingly. People can still run code on 1.5, but testing should stay up to date.

craffel commented 7 years ago

Ok, thanks.

re-generate the test cases accordingly

How did you generate the test cases in the first place?

bmcfee commented 7 years ago

Ran the tests functions, checked the output manually, and then copied over to baseline images.

I can take care of this in a few days.

craffel commented 7 years ago

Ok, cool.