bss_eval_images_framewise should precompute the projection matrices

craffel / mir_eval

Evaluation functions for music/audio information retrieval/signal processing algorithms.

MIT License

604 stars 112 forks source link

bss_eval_images_framewise should precompute the projection matrices #270

Open aliutkus opened 6 years ago

aliutkus commented 6 years ago

When calling separation.bss_eval_images_framewise, I believe that the projection matrix should be computed once and for good on the whole signal, instead of being computed anew at each frame as I understand is done now

carlthome commented 6 years ago

Wow, yes please!