craffel / mir_eval

Evaluation functions for music/audio information retrieval/signal processing algorithms.
MIT License
604 stars 112 forks source link

[WIP] chord.evaluate with extension reductions. implements #274 #275

Open bmcfee opened 6 years ago

bmcfee commented 6 years ago

This PR implements extension-reduction in the chord metrics.

It's currently WIP, as it has uncovered some undocumented quirks in chord eval that I'd like to get settled before we merge this.

ejhumphrey commented 6 years ago

well then, i'm pleasantly surprised this works. lgtm so far

grumble chords grumble

bmcfee commented 6 years ago

well then, i'm pleasantly surprised this works. lgtm so far

grumble chords grumble

The strange thing is that the test case hits on thirds, triads, and tetrads, but fails only on sevenths. (And majmin, I guess, maybe we should consider changing that one...)

bmcfee commented 6 years ago

(warning: nitpicking to follow. sorry!)

I'm going through the chord metrics implementation, just to see if there are any other likely oddities. Here are some things I've noticed that seem strange: