search

craffel / mir_eval

Evaluation functions for music/audio information retrieval/signal processing algorithms.
MIT License
588 stars 109 forks source link

fixed deprecations and updated requirements #277

Closed bmcfee closed 6 years ago

bmcfee commented 6 years ago

This PR fixes #276 by updating the display, segment, and doc build to reflect recent deprecations. Version requirements have been updated accordingly.

There should be no functionality change here.

bmcfee commented 6 years ago

@craffel i think this one's good to go. The only question mark is whether you're okay with bumping the scipy version up to 1.0. (It's been almost a year at this point, I think it should be okay.)

craffel commented 6 years ago

Looks good. Looks like there is one more deprecation warning in the CI, not sure if you want to fix here or not: https://travis-ci.org/craffel/mir_eval/jobs/385206565#L1232

bmcfee commented 6 years ago

Yeah, I noticed that. It's in the image comparison tests, and I think out of scope for what I want to do here. A proper fix for that would be included in #269 .

craffel commented 6 years ago

Cool. Thanks for this!